(12-23-2013, 01:11 AM)Romulator Wrote: I went through the OP code and corrected most of your errors. Some of them you will have to fix on your own because I do not know exactly where they have to go, or why they are there. I commented any changes and notes you need to take care of. I also did some aligning so I could understand your coding a little better.

I also noticed DnALANGE beat me to it Though either of ours should suffice, unspoiler mine if you need to

Spoiler below!

PHP Code:

void OnStart()                                                                        //The AddCallbacks were not within a void. Placed within OnStart().
    { 
    AddUseItemCallback("", "Crowbar", "Door", "UseCrowbarOnDoor", true);
    AddEntityCollideCallback("Joint", "AreaBreak", "BreakDoor", true, 1);
    }

void PickupKey(string &in asEntity, string &in asItem)
    { 
    AddQuest("quest1", "TestQuest");
    AddUseItemCallback("", "MasterBedroomKey", "bedroomdoor","UseMasterBedroomKey", true);
    AddEntityCollideCallback("Player", "AreaMemento", "EventQuest", true, 1);
    }                                                                            //Missing closing brace


void UseMasterBedroomKey(string &in asItem, string &in asEntity)
    {
    SetMessage("message", "message1", 3.0f);            //Changed from integer to float. Does not affect the way it is run however.
    }


AddTimer("", 1.1, "TimerDoorCanClose");                    //AddTimer() can only be used within a routine (void). Collide with a scriptarea if necessary. Move it or give it a void as necessary.
                                                        //Moved brace to under the below void.

void TimerDoorCanClose(string &in asTimer)
    {
    SetSwingDoorDisableAutoClose("Door", false);
    }


void UseCrowbarOnDoor(string &in asItem, string &in asEntity)
    {
    RemoveItem(asItem);
    PlaySoundAtEntity("", "player_crouch.snt", "Player", 0.05f, false);
    AddTimer(asEntity, 0.2f, "TimerPlaceCrowbar");
    }

void TimerPlaceCrowbar(string &in asTimer)
    {
    SetEntityActive("Joint", true);
    PlaySoundAtEntity("", "puzzle_place_jar.snt", asTimer, 0, false);
    }

void BreakDoor(string &in asParent, string &in asChild, int alState)
    {
    SetEntityActive("Joint", false);
    SetEntityActive("Broken", true);
    SetSwingDoorLocked("Door", false, false);
    SetSwingDoorClosed("Door", false, false);
    SetSwingDoorDisableAutoClose("Door", true);
    AddPropImpulse("Door", 0, 0, 3, "world");
    CreateParticleSystemAtEntity("", "ps_hit_wood.ps", "Areaeffect", false);
    PlaySoundAtEntity("", "break_wood_metal", "Areaeffect", 0, false);
    GiveSanityBoostSmall();
    PlayMusic("10_puzzle01.ogg", false, 0.7f, 0.1f, 10, false);
    AddTimer("", 0.1f, "TimerPushDoor");
    }

void TimerPushDoor(string &in asTimer)
    {
    AddPropImpulse("Door", -4, 2, 1, "world");
    AddTimer("", 1.1f, "TimerDoorCanClose");
    }

//void TimerDoorCanClose(string &in asTimer)                    //This code has been used before. May cause errors when called again in code.
//{                                                                //It is easier to call a new timer and use that instead.
//SetSwingDoorDisableAutoClose("Door", false);                    //And it is missing a closing brace :P
//}

void touchdoor(string &in asEntity, string &in type)
    {
    AddQuest("door", "touchdoor");
    }


void EventQuest(string &in asParent, string &in asChild, int alState)
    {
    AddQuest("area", "enterarea");
    }

void touchdoor(string &in asEntity)                                //You cannot name two routines after the same void. Change this to touchdoor_2 or something.
    {                                                            //You will need to change any codes/messages as well which point to here.
    AddQuest("door", "touchdoor");
    } 


If you find you cannot read it well because of browser limitations, download it from here

(12-23-2013, 01:41 AM)Romulator Wrote: Whether they are floats or integers, they would still pass correctly in most cases, unless it is a decimal value.

And in response, yes. There are one or two things you need to check:
1. Your AddTimer in the middle of the code. Place it somewhere in the code within a void. I don't know what is supposed to happen, so if you need to, make the player collide with a ScriptArea and make some appropriate code for that:

PHP Code:

OnStart()
{
AddEntityCollideCallback("Player", "ScriptArea_Name", "StartTimer", "true", 1);
}

void StartTimer(string &in asParent, string &in asChild, int alState)
{
AddTimer("", 1.1, "TimerDoorCanClose");
} 


Just change the ScriptArea_Name to whatever in your Level Editor, and make it big enough for the player to walk through, similar to this:


And the second thing is right down the bottom, you have two touchdoor voids, which you cannot I said what to do about that though.

---

Dont worry DNaLANGE. It's all about assistance. You managed to get him from 4 errors to 1, so it's all about progress

(12-23-2013, 01:56 AM)DnALANGE Wrote: Meaning you have a COPY of the same name somewhere
in YOUR case it´s THIS :
touchdoor

(12-23-2013, 01:56 AM)DnALANGE Wrote: Meaning you have a COPY of the same name somewhere
in YOUR case it´s THIS :
touchdoor
-
You can NOT use the same name twice in a script.
Just make it toutchdoor1 or whatever will work.
-
USE Notepad++, THEN you cans ee what is good and NOT good, It's free o use.
Try google it up.

(12-23-2013, 02:04 AM)Romulator Wrote: Could you perhaps explain why it needs to be there twice? I don't see anything to assume it must...

(12-23-2013, 01:56 AM)DnALANGE Wrote: Meaning you have a COPY of the same name somewhere
in YOUR case it´s THIS :
touchdoor
-
You can NOT use the same name twice in a script.
Just make it toutchdoor1 or whatever will work.
-
USE Notepad++, THEN you cans ee what is good and NOT good, It's free o use.
Try google it up.