[SCRIPT] Why won't this script work?

[ferryadams10]

Hi guys.

What I'm trying to do is make the SlideDoor2 go open when I've set all levers in a proper order.

lever_1, 3 and 4 should be down

lever_2 and 5 should be up.

But.. Now the PerformLeverTaskCompleted starts working as soon as I pull just a random lever.

Please help me to make the SlideDoor2 open when I put em in the right order.

PHP Code: (Select All)

////////////////////////////
// Run first time starting map
void OnStart()
{
//START LEVER PUZZLE//
 SetEntityConnectionStateChangeCallback("lever_1", "StoreCheckLeverState");
 SetEntityConnectionStateChangeCallback("lever_2", "StoreCheckLeverState");
 SetEntityConnectionStateChangeCallback("lever_3", "StoreCheckLeverState");
 SetEntityConnectionStateChangeCallback("lever_4", "StoreCheckLeverState");
 SetEntityConnectionStateChangeCallback("lever_5", "StoreCheckLeverState");
 SetEntityConnectionStateChangeCallback("lever_6", "StoreCheckLeverState");
//END LEVER PUZZLE//
}
//START LEVER PUZZLE//
void CheckLeverStates()
{
 if (GetLocalVarInt("lever_1") == -1
 && GetLocalVarInt("lever_2") == 1
 && GetLocalVarInt("lever_3") == -1
 && GetLocalVarInt("lever_4") == -1
 && GetLocalVarInt("lever_5") == 1
 && GetLocalVarInt("lever_6") == 1)
{
 PerformLeverTaskCompleted();
}
}
void PerformLeverTaskCompleted()
{
 SetMoveObjectStateExt("SlideDoor2", 1.0f, 1.0f, 1.0f, 0.0f, false);
}
void StoreCheckLeverState(string &in entity, int state)
{
 SetLocalVarInt("lever_1", -1);
 SetLocalVarInt("lever_2", 1);
 SetLocalVarInt("lever_3", -1);
 SetLocalVarInt("lever_4", -1);
 SetLocalVarInt("lever_5", 1);
 SetLocalVarInt("lever_6", 1);
 CheckLeverStates();
} 
//END LEVER PUZZLE// 


[palistov]

Your syntax is all correct but your semantics is all out of whack. Semantics is basically programming "grammar", while syntax is programming "spelling". Your code is syntactically correct, but if you take a look at your function StoreCheckLeverState, you'll notice that no matter what lever is pulled, the variables are all set to the correct state. Hence, the player can pull any one lever and solve the puzzle. To solve this, use this function instead

PHP Code: (Select All)

void StoreCheckLeverState(string &in entity, int state)
{
if(entity == "lever_1") SetLocalVarInt("lever_1", state);
if(entity == "lever_2") SetLocalVarInt("lever_2", state); 
if(entity == "lever_3") SetLocalVarInt("lever_3", state); 
if(entity == "lever_4") SetLocalVarInt("lever_4", state); 
if(entity == "lever_5") SetLocalVarInt("lever_5", state); 
if(entity == "lever_6") SetLocalVarInt("lever_6", state);
CheckLeverStates(); 
} 


Good luck

[Dobbydoo]

Your syntax is all correct but your semantics is all out of whack. Semantics is basically programming "grammar", while syntax is programming "spelling". Your code is syntactically correct, but if you take a look at your function StoreCheckLeverState, you'll notice that no matter what lever is pulled, the variables are all set to the correct state. Hence, the player can pull any one lever and solve the puzzle. To solve this, use this function instead

PHP Code: (Select All)

void StoreCheckLeverState(string &in entity, int state)
{
if(entity == "lever_1") SetLocalVarInt("lever_1", state);
if(entity == "lever_2") SetLocalVarInt("lever_2", state); 
if(entity == "lever_3") SetLocalVarInt("lever_3", state); 
if(entity == "lever_4") SetLocalVarInt("lever_4", state); 
if(entity == "lever_5") SetLocalVarInt("lever_5", state); 
if(entity == "lever_6") SetLocalVarInt("lever_6", state);
CheckLeverStates(); 
} 


Good luck

It would be much easier to have only one variable for all levers. Then every time you pull a lever you add one to the variable and when it reaches 6 the puzzle is completed.

[Your Computer]

There's no point to check for the lever name from the entity variable if the local map variable carries the same name.

PHP Code: (Select All)

void StoreCheckLeverState(string &in entity, int state)
{
SetLocalVarInt(entity, state);
CheckLeverStates(); 
} 


It would be much easier to have only one variable for all levers. Then every time you pull a lever you add one to the variable and when it reaches 6 the puzzle is completed.

That would be error prone. Even if we set a stuck state for each lever when it gets pulled correctly, you'd still be adding 1 for when it gets pulled in the opposite, undesired direction.

[ferryadams10]

Thanks allot.

It worked

[palistov]

Your Computer, just showing him the simplest and easiest-to-understand solution

[Dobbydoo]

There's no point to check for the lever name from the entity variable if the local map variable carries the same name.

PHP Code: (Select All)

void StoreCheckLeverState(string &in entity, int state)
{
SetLocalVarInt(entity, state);
CheckLeverStates(); 
} 


It would be much easier to have only one variable for all levers. Then every time you pull a lever you add one to the variable and when it reaches 6 the puzzle is completed.

That would be error prone. Even if we set a stuck state for each lever when it gets pulled correctly, you'd still be adding 1 for when it gets pulled in the opposite, undesired direction.

Not if he only added to the variable when it was in the right state, and maybe made it stuck when in that state.
Like this:

PHP Code: (Select All)

if(alState == 1)
 {
 SetLeverStuckState(string& asName, int alState, bool abEffects);
 AddLocalVarInt(string& asName, int alVal);
 } 


EDIT: And of course when not being in the right state one would be removed from the variable.

[ferryadams10]

Haha thanks Dobbydoo but it was already working ^^

Thanks for being so helpfull against me anyways