[SCRIPT] Parentheses issue

[Grimm101]

Hey guys,

EDIT: Updated the script and managed to remove the error for line 20 but my current error is it points to the bracket below void doorclosebang

I've got an issue when I start my level, I want to make a door slam when I walk into a specific area and play a sound when it happens. I am getting an error on line 20 and line 25. Which are both curly brackets. I'm not sure what this means. This is my code below. The 20th line can be seen below //Triggers

PS: I'm new to PHP/C++ and I think this a good starting point. I'm good with VB and Ok ish with C#. So far i've found this the easiest code to understand and read fluently but this kind of issue I am unsure of. I'm sure it is something simple and silly. =)

Thanks

PHP Code: (Select All)

////////////////////////////////
// Run when starting the map
void OnStart()

////////////////////////////////
// Entities
{
    AddUseItemCallback("", "Bedroom_Key", "Bedroom_Key_Door", "UsedKeyOnDoor", true); //Assigns the key to the door and sets the action of this as UsedKeyOnDoor
    AddEntityCollideCallback("Player", "DoorCloseArea1", "DoorCloseBang", true, 1); // Declaring when a player walks into an area called "Name" Deletes the possibility of it happening again so it can only happen once: Number = 1 for player enters. -1 for when player leaves. 0 for both
}

void UsedKeyOnDoor(string &in asItem, string &in asEntity) //Declaring the Key as a string 
{
        SetSwingDoorLocked("Bedroom_Key_Door", false, true); //Sets what door the key works on and it can only be used once
            PlaySoundAtEntity("", "unlock_door", "Bedroom_Key_Door", 0, false); //Plays sound when the key is used on the door
            RemoveItem("Bedroom_Key"); //Removes the key after it has been used
}

////////////////////////////////
// Triggers

void DoorCloseBang(string &in asParent, string &in asChild, int alState); 
{
    SetSwingDoorClosed("Bedroom_Key_Door", true, true); //Closes a swing door: Effects indicate true to see the door close
    PlaySoundAtEntity("", "bang", "DoorCloseBang", 0, false); //Create banging on the door sound when the door shuts
}

////////////////////////////////
// Run when entering the map
void OnEnter()
{

}

////////////////////////////////
// Run when leaving the map
void OnLeave()
{

} 


[Your Computer]

I have trouble believing that is how your script actually looks. Could you edit your post with the forum's source editor and replace the script with the actual script?

[Grimm101]

Sorry mate didn't notice, there you go. I made an edit.

---

I notice that my post seems to be unexplained. After the recent changes I have made I fixed one of the issues. I understand that the main commands need to be under the same bracket. I can't put the code below anywhere else. My error says: "ERR Unexpected Token '{'" It seems it is to do with the bracket which holds the code below. I am not sure what to do.


SetSwingDoorClosed("Bedroom_Key_Door", true, true); //Closes a swing door: Effects indicate true to see the door close
PlaySoundAtEntity("", "bang", "DoorCloseBang", 0, false); //Create banging on the door sound when the door shuts

[Your Computer]

You have a semicolon as part of the DoorCloseBang function header. That's a big no-no for function definitions.

[Apjjm]

You have a semi-colon at the end of

Code: (Select All)

void DoorCloseBang(string &in asParent, string &in asChild, int alState); 

Edit: Ninja'd

[Grimm101]

See, I knew it would be something stupid!! Thanks guys!! Your a great help.

---

I have a new issue with my code. It works fine and everything but as you can see, I want a sound to be played when the door shuts. The sound called "Bang.snt" Currently there is no sound being played. This is my new code

PHP Code: (Select All)

////////////////////////////////
// Run when starting the map
void OnStart()

////////////////////////////////
// Entities
{
    AddUseItemCallback("", "Bedroom_Key", "Bedroom_Key_Door", "UsedKeyOnDoor", true); //Assigns the key to the door and sets the action of this as UsedKeyOnDoor
    AddEntityCollideCallback("Player", "DoorCloseArea1", "DoorCloseBang", true, 1); // Declaring when a player walks into an area called "Name" Deletes the possibility of it happening again so it can only happen once: Number = 1 for player enters. -1 for when player leaves. 0 for both
}

void UsedKeyOnDoor(string &in asItem, string &in asEntity) //Declaring the Key as a string 
{
        SetSwingDoorLocked("Bedroom_Key_Door", false, true); //Sets what door the key works on and it can only be used once
            PlaySoundAtEntity("", "unlock_door.snt", "Bedroom_Key_Door", 0, false); //Plays sound when the key is used on the door
            RemoveItem("Bedroom_Key"); //Removes the key after it has been used
}

void DoorCloseBang(string &in asParent, string &in asChild, int alState) 
{
    SetSwingDoorClosed("Bedroom_Key_Door", true, true); //Closes a swing door: Effects indicate true to see the door close
    PlaySoundAtEntity("", "bang.snt", "DoorCloseBang", 0, false); //Create banging on the door sound when the door shuts
}

////////////////////////////////
// Run when entering the map
void OnEnter()
{

}

////////////////////////////////
// Run when leaving the map
void OnLeave()
{

} 


[Your Computer]

Where is bang.snt found in the original Amnesia sounds? Or did you make your own .snt file and called it bang?

[Grimm101]

Where is bang.snt found in the original Amnesia sounds? Or did you make your own .snt file and called it bang?

It's in "amnesia the dark descent/sounds/24"

Cheers =]

[Your Computer]

Whether in 15 or 24, mine has a number in front on the name. Doesn't your's have a number prefixed too?

[Grimm101]

Yep I literally just noticed that too, added the number making it "24_Bang.snt" and still no sound. Is it correct of me to have "DoorCloseBang"? That is what I am unsure of.