Need help fixing a bug in a script

[Koopa Rs07]

(BUG IS FIXED)

I didn't make the script, it was copied from the main game and then tweaked by someone who has better knowledge than me. So I have no clue how to fix it. If anyone is willing to help me, pm me. I will put your name in the credits of my cs.

[Romulator]

No offense, but you're better to just post the script to get the help required; we're a forum. On a forum, you openly contribute If it's too much of a spoiler, then post the most relevant sections of code.

Does an error pop up or the game just continue like normal? If an error pops up, then you can use the information to determine the location of your code faults.

If the game continues as normal, the best way to check for errors is by using Script Debug codes.

Set up the Developer Environment here, if you have not already;
https://wiki.frictionalgames.com/hpl2/am...evenvguide

Then use to print messages to determine which voids functions are working in your game:

PHP Code: (Select All)

void AddDebugMessage(string& asString, bool abCheckForDuplicates); 


Moving to Development Support.

[Spelos]

Besides, many of the original scripts use optimization techniques to ease their job a little.

For example in order to not have to wright the same code multiple times, the might just create custom functions.

PHP Code: (Select All)

void OnStart()
{
    if(areAllQuestsCompleted)
        SpawnStuff("Enemy", true);
}

void SpawnStuff(string whatToSpawn, bool effects)
{
    SetEntityActive(whatToSpawn, true);
    if(effects)
    {
        PlayMusic("music.ogg", true, 1.0f, 1.0f, 1, false);
        GiveSanityDamage(10.0f, true);
    }
}

bool areAllQuestsCompleted()
{
    if(QuestIsCompleted("lastQuest"))
    {
        return true;
    }
    return false;
} 


Some of those functions might be even used in a totally different part of the script and need to be declared only once. Therefore it is possible that you did not copy one of those functions.

But it's very difficult to know without seeing the code.

[WALP]

EDIT: SEEMS THREAD MIGHT BE GETTING CLOSED, SO PLEASE REPLY HERE INSTEAD
https://www.frictionalgames.com/forum/thread-40412.html

just letting you people know the issue has been fixed.

When reading frictionals code however, I discovered a piece of code I initially thought was retarded, but upon closer inspection seemed to be a workaround for a tricky code issue, and I was wondering what the ideal way to implement something like it would have been. You can take a look at the actual code yourself in the 03_archives.hps, but in short it goes like this:

PHP Code: (Select All)

void CollideSecretBook(string &in asBook, string &in asCollideArea, int BookState)
{
    AddTimer(asBook,20,"PushBackBook1"); //name of the timer(asTimer) = name of the book being pulled out(asBook)
}

PushBackBook1(string &in asTimer)
{
    SetPropObjectStuckState(asTimer, -1); //Pushes the book back
    AddTimer("2"+asTimer, 0.25f, "PushBackBook02"); //then just 0.25 seconds later the same book is put into the normal state. 
}

PushBackBook2(string &in asTimer)
{
    if(asTimer == "2SecretBook_1") 
    {
        SetPropObjectStuckState("SecretBook_1", 0);
    }
    else if(asTimer == "2SecretBook_2") 
    {
        SetPropObjectStuckState("SecretBook_2", 0);
     }
    else 
    {
        SetPropObjectStuckState("SecretBook_3", 0);
    }
} 


Basically PushBackBook1 and PushBackBook2 do almost the same thing, but for some reason PushBackBook2 needs code for every single book while the other simply got the name of the book from the timer name.

The reason for this is that the timer that calls PushBackBook2, cant be named the same as the Book, since there's already a timer for PushBackBook1 with the very same name.
Hence the scripter had to rename the timer with the "2" in front, but the problem with doing this was that now he could not use the timer name anymore to pass on the name of the book, so instead of just writing:

SetPropObjectStuckState(asTimer, 0);

He had to go through and script for every single timer name

if(asTimer == "2SecretBook_1")
{
SetPropObjectStuckState("SecretBook_1", 0);
}
else if(asTimer == "2SecretBook_2")
{
SetPropObjectStuckState("SecretBook_2", 0);
}
else
{
SetPropObjectStuckState("SecretBook_3", 0);
}


This seems terribly messy, and I cant help but feel there has to be some way that the name of Book can be passed on directly from PushBackBook1 to PushBackBook2.

Any ideas?

[Koopa Rs07]

(BUG IS FIXED)
Mods can tear this thread down now if they so please.

[Romulator]

I'll keep it for the moment because there's a bit of discussion proposed by WALP. After that, I'll consider closing it, since we don't usually delete Dev Support threads~

Oh! Never mind, WALP started a new thread on the issue. Closing

If you want to discuss WALP's code above, please refer to here:
https://www.frictionalgames.com/forum/thread-40412.html