[SOLVED] In-game clock not working

[DanielRand47]

Hello everyone. I am at work on a mod that will feature an in-game clock. The goal is to have the time be visible throughout the entire mod. The timer works in the first map. However, I have experienced some issues when transfering the values from one map to another. I have attached an image of the errors received.

Error Message


I have also included the code as well. (Note that I will start it at line 36 in 02_Cellar.map.)

Code: 01_House.map (OnLeave only)

PHP Code: (Select All)

void OnLeave()
{
    AddTimer("Stop", 0.1f, "MasterTimer");

    SetGlobalVarInt("Hours", gameHours);
    SetGlobalVarInt("Minutes", gameMinutes);
    SetGlobalVarFloat("TimeScale", timeScale);
} 


Code: 02_Cellar.map

PHP Code: (Select All)

int gameHours = GetGlobalVarInt("Hours");
int gameMinutes = GetGlobalVarInt("Minutes");
float timeScale = GetGlobalVarFloat("TimeScale");

void MasterTimer(string &in asTimer)
{

    if(asTimer == "Stop")
    {
        RemoveTimer("Tick");
    }
    else if(asTimer == "Initialize")
    {    
        ChangeTime(gameHours, gameMinutes,"Set");
        AddTimer("Tick", timeScale, "MasterTimer");
    }
    else if(asTimer == "Tick")
    {
        ChangeTime(0,1,"Add");
        AddTimer("Tick", timeScale, "MasterTimer");
    }

    SetMessage("TimeValues", "" + gameHours + ":" + gameMinutes, 0.0f);
}

void ChangeTime(int hours, int minutes, string changeMode)
{
    if(changeMode == "Add")
    {
        gameHours += hours;
        gameMinutes += minutes;
        
        // Add hours till minutes are less than 60
        while(gameMinutes > 59)
        {
            gameHours++;
            gameMinutes -= 60;
        }
    }
    else if(changeMode == "Set")
    {
        gameHours = MathClamp(hours, 0, 23);
        gameMinutes = MathClamp(minutes, 0, 59);
    }
    
    // Support Outside Function
    // Does any time-update commands.
    OnTimeUpdate();
}

void OnEnter()
{
    PlaySoundAtEntity("cellarambience", "13_amb.snt", "Player", 1.0f, false);
    AddTimer("Initialize", 2.0f, "MasterTimer");
}

void OnLeave()
{
    StopSound("cellarambience", 1.0f);
    AddTimer("Stop", 0.1, "MasterTimer");
} 


I have tried everything from commenting out certain sections of code, moving variables around, conversions, and making sure spelling is correct. No positive results have shown. It seems that it may have something to do with the global variables. However, I do not know why they are not working. If anyone could provide some insight as to what the issue is, that would be greatly appreciated.

Many thanks!!

[Romulator]

Try putting your Global Vars into a file called global.hps in your /maps directory, with this code.

PHP Code: (Select All)

void OnGameStart()
{
    SetGlobalVarInt("Hours", gameHours);
    SetGlobalVarInt("Minutes", gameMinutes);
    SetGlobalVarFloat("TimeScale", timeScale);
} 


Then remove the SetGlobalVars in your OnLeave();.

You should also start a new game when testing this, since OnGameStart() is only called when you click "New Game" from the menu.

[Mudbill]

One thing you can try is to

PHP Code: (Select All)

int gameHours;
int gameMinutes;
float timeScale;

void OnEnter() {
    gameHours = GetGlobalVarInt("Hours");
    gameMinutes = GetGlobalVarInt("Minutes");
    timeScale = GetGlobalVarInt("TimeScale");
} 


Perhaps that will fix, if not all but some of the problems.

Another thing is I don't think timers run across maps, so your "Stop" timer from OnLeave might not run in the second map, but rather wait until you return to the original map. Not 100% sure here though.

[DanielRand47]

Try putting your Global Vars into a file called global.hps in your /maps directory, with this code.

PHP Code: (Select All)

void OnGameStart()
{
    SetGlobalVarInt("Hours", gameHours);
    SetGlobalVarInt("Minutes", gameMinutes);
    SetGlobalVarFloat("TimeScale", timeScale);
} 


Then remove the SetGlobalVars in your OnLeave();.

You should also start a new game when testing this, since OnGameStart() is only called when you click "New Game" from the menu.

Alright thanks. I'll do that!

---

One thing you can try is to

PHP Code: (Select All)

int gameHours;
int gameMinutes;
float timeScale;

void OnEnter() {
    gameHours = GetGlobalVarInt("Hours");
    gameMinutes = GetGlobalVarInt("Minutes");
    timeScale = GetGlobalVarInt("TimeScale");
} 


Perhaps that will fix, if not all but some of the problems.

Another thing is I don't think timers run across maps, so your "Stop" timer from OnLeave might not run in the second map, but rather wait until you return to the original map. Not 100% sure here though.

Your solution works! Thanks for this advice! Now to do as Romulator suggested and put them into a global.hps file.

[Spelos]

Thanks for using my scripts... Although, I'll create a multiple map support soon. =D

[DanielRand47]

Thanks for using my scripts... Although, I'll create a multiple map support soon. =D

That would be awsome man! Something that will make transfering the hours and minutes easier to use. Right now I am having to store them in the GlobalVarInt/Float function, declare and reinitialize the variables that are global to the script file and then update the GlobalVarInt/Float function when I leave the map. Tedious but it does the job. I will say I hope more mods use this time mechanic.