Timer not stopping

[Damascus]

PHP Code: (Select All)

void OnStart()
{
    for (int i = 0; i < 14; i++)
    {
        AddEntityCollideCallback("Player", "ShadowArea_"+i, "ShadowDamage", true, 0);
    }
}

void ShadowDamage(string &in asParent, string &in asChild, int alState)
{
    if (alState == 1)
    {
        AddTimer("damage", 2.0f, "TimerDamage");
    }
    else if (alState == -1)
    {
        RemoveTimer("damage");
    }
}

void TimerDamage(string &in asTimer)
{
    GivePlayerDamage(20, "BloodSplat", true, true);
    PlayGuiSound("attack_claw_hit.snt", 0.5f);
    AddTimer("damage", RandFloat(5.0f, 7.0f), "TimerDamage");
} 


I'm trying to make an area that damages you ever 5-7 seconds while you're inside, but stops damaging you when you leave it. However, even after I leave the area, I keep getting damaged over and over. Am I missing something here?

[FlawlessHappiness]

You can make the whole timer activate if a variable is 1
Then set it to 0 to make the timer not call


Timers that call themselves can be tricky

[TheGreatCthulhu]

I'm trying to make an area that damages you ever 5-7 seconds while you're inside, but stops damaging you when you leave it. However, even after I leave the area, I keep getting damaged over and over. Am I missing something here?

You could try something like this - of the top of my head:

PHP Code: (Select All)

// NOTE: I'll use
      // <----------------
// to mark the important points.
// This assumes that the damage areas don't overlap.


// Add a bool variable here to use as an indicator
bool isInsideDamageArea = false;    // <---------------

void OnStart()
{
    for (int i = 0; i < 14; i++)
    {
        AddEntityCollideCallback("Player", "ShadowArea_"+i, "ShadowDamage", true, 0);
    }
}

void ShadowDamage(string &in asParent, string &in asChild, int alState)
{
    // Set isInsideDamageArea:
    // will be true if state == 1 (on enter area event),
    // otherwise false.
    isInsideDamageArea = (state == 1);   // <-----------------    

    if (alState == 1)
    {
        AddTimer("damage", 2.0f, "TimerDamage");
    }
    else if (alState == -1)
    {
        RemoveTimer("damage");
    }
}

void TimerDamage(string &in asTimer)
{
    // Wrap everything inside an if-statement:

    if(isInsideDamageArea)    // <---------------
    {
        GivePlayerDamage(20, "BloodSplat", true, true);
        PlayGuiSound("attack_claw_hit.snt", 0.5f);
        AddTimer("damage", RandFloat(5.0f, 7.0f), "TimerDamage");
    }
} 


[Damascus]

I figured out what my (stupid) mistake was.

AddEntityCollideCallback("Player", "ShadowArea_"+i, "ShadowDamage", true, 0);

This had to be false, cause the callback is autoremoved otherwise.

[TheGreatCthulhu]

Oh, I missed that! Good.